Merged
Conversation
Contributor
Author
|
(The preview is failing because I went ahead and edited the intro for the ON chapter as well for consistency) |
jkostiuk
approved these changes
May 7, 2026
Contributor
jkostiuk
left a comment
jkostiuk
left a comment
There was a problem hiding this comment.
Nice, I like! I don't have a specific suggestion and don't think we should wait, but I thought it was funny that the intro for MX is the one emphasizing "Algebraic" properties. Don't disagree with the characterization of the intro at all tho.
Contributor
Author
Feel free to suggest tweaks when you have time to think about it. I really wanted to use the word "ring" in there, but alas, not for this course's audience... 🙃 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #957
@jkostiuk You may have suggestions on the introductory text I added, feel free to edit or suggest improvements.